reloadData if diffing before refreshViews if diffing is disabled (#127) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The downside to what we did here is that 0.1.2 will not get this patch, which effectively makes it a release we never want to use in PG. Instead, we should make a 0.1.3 that includes this patch, if we decide we want to upgrade to 0.1.2. |
benasher44
force-pushed
the
basher/0.1.1-patch1-cp
branch
from
69f0a3e to
1071975
Compare
|
Superseded by #130 |
|
Re-opening, since we ditched #130 |
This calls reloadData on self.tableView when diffing is disabled. This ensures that the UITableView is in sync with new data model before attempting to call methods on UITableView that would require the data model to be in sync to get correct results (i.e. cellForRow(at:)). This prevents crashing in cellForRow(at:) when UITableView asks for cells near a user-requested (programmatically), when the data model may not actually have the data for that cell. (cherry picked from commit eb3bb93)
benasher44
force-pushed
the
basher/0.1.1-patch1-cp
branch
from
1071975 to
b44c8a6
Compare
benasher44
added a commit
that referenced
this pull request
Aug 20, 2018
- Updates CHANGELOG to include info about fix from #128 - Updates the podspec - Makes 0.2.0 the "next" release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #127