install mypy + update dev deps + update pre commit + begin type hinting #292
Conversation
.gitignore
Outdated
| .mypy_cache | ||
|
|
||
| #swagger_ui | ||
| flask_rebar/swagger_ui |
There was a problem hiding this comment.
this directory hasn't been updated in 2 years, but it has a lot of large files that result in noisy matches when you search in the repo (I use ag to search). wondering if we can .gitignore it and someone who needs to actively update this directory can remove on a case by case basis?
There was a problem hiding this comment.
That directory contains the minimized swagger ui files that we vendor with flask-rebar. It actually is being updated right now in this PR to support Open API 3.1
We should not gitignore a file because it's causing noisy matches when searching the file systems. That is the wrong use of the gitignore file.
Your file system searching tool of choice should have a method of excluding directories from the search. In the case of ag it looks like adding this pattern to a .ignore file should hopefully resolve your problem. 😄
| @@ -1,4 +1,5 @@ | |||
| from collections import namedtuple | |||
| from typing import Type | |||
There was a problem hiding this comment.
this import is required for python <= 3.8, 3.9 and later support type[]
.gitignore
Outdated
| .mypy_cache | ||
|
|
||
| #swagger_ui | ||
| flask_rebar/swagger_ui |
There was a problem hiding this comment.
That directory contains the minimized swagger ui files that we vendor with flask-rebar. It actually is being updated right now in this PR to support Open API 3.1
We should not gitignore a file because it's causing noisy matches when searching the file systems. That is the wrong use of the gitignore file.
Your file system searching tool of choice should have a method of excluding directories from the search. In the case of ag it looks like adding this pattern to a .ignore file should hopefully resolve your problem. 😄
This is basically the minimum required code in order to get
mypy .to pass. In future PR(s) I will work through untyped definitions and add type hints to everything, with the end goal being to setcheck_untyped_defs = Truein the config for the entire repo.Also I was getting an error because the pinned version of jsonschema doesn't work with python 3.11 when I run tests on my laptop (it seems to work OK in CI/CD for some reason). I went ahead and updated all dev deps to latest possible version to get past this.
Also ran
pyupgradeto remove old compatibility code since we now require python3.8+