Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an option to have more verbose error messages and set the default value to false #860

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Conversation

Nounoursdestavernes
Copy link
Contributor

@Nounoursdestavernes Nounoursdestavernes commented Aug 28, 2024

Hi,

This PR add a new option that can be config through the ENABLE_VERBOSE_ON_LOGIN env var. (This name can be change, not the best one I concede).

Default value is false. The error message when failling to login is Invalid Credentials.

Setting to true will enable verbose.
Error messages become Invalid email or username or Invalid password (Current behaviour).

This setting must be set to true only if rate limiter is enable. Otherwise this could lead to a security issue. (cf owasp )

Best regards,

@Nounoursdestavernes Nounoursdestavernes changed the title fix: more generic error messages on login feat: Add an option to have more verbose error messages and set the default value to false Aug 28, 2024
@meltyshev meltyshev merged commit e6644eb into plankanban:master Aug 30, 2024
1 check passed
@meltyshev
Copy link
Member

Thanks again! I've changed the name of the variable a bit, hope you don't mind :)

@Nounoursdestavernes
Copy link
Contributor Author

No problem, yours is better ! And sorry for the quality of the code (and thx for improving it)

@meltyshev
Copy link
Member

No problem, yours is better ! And sorry for the quality of the code (and thx for improving it)

You don't have to apologize! The quality is great. I basically swapped the lines of code to ensure the order is consistent everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants