Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ItemProperties module and Monster Resistances to healthbar #7

Closed
wants to merge 0 commits into from
Closed

Conversation

dschu012
Copy link

@dschu012 dschu012 commented May 16, 2018

This is kind of half baked and probably requires a bit of testing around with/toggles to enable disable. But the gist of a solution for displaying the min-max values of rolls is there. 95% of the code is from https://github.com/lolet/D2Ex2/blob/master/ExScreen.cpp#L807 with offsets ported over to 1.13c

image

@dschu012
Copy link
Author

And I just saw #6 😢

@dschu012
Copy link
Author

dschu012 commented Aug 5, 2018

Added custom display for monster resists/missing health.

image

@dschu012 dschu012 changed the title Add ItemProperties module Add ItemProperties module and Monster Resistances to healthbar Aug 13, 2018
@planqi
Copy link
Owner

planqi commented Oct 24, 2018

There is at least one issue with the variable stats display: it can hide or misrepresent a Adds 10-20 Damage type of damage modifier. So far I've seen non weapons where the stat is hidden and weapons where it displays it as +20 to maximum damage instead. That's the main reason #6 hasn't been merged yet.

Also, what's going on with BH/Constants.h and BH/D2Structs.h - was that a file/endline encoding change? I try to keep things like that as is to help other PRs. If code cleanup like that must be done, it should be in a separate PR.

I'd love to isolate the monster res display in a separate PR.

@dschu012 dschu012 closed this Nov 14, 2018
arolds pushed a commit to arolds/slashdiablo-maphack that referenced this pull request Oct 22, 2021
…re/show-more-items

Revert "Dschu012 feature/show more items"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants