forked from open-telemetry/opentelemetry-go-contrib
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
specialize simplelru(span's lruMap) for attributes only (#328)
* copy of simplelru for attributes without excessive usage of interface{}
This also make sure we only add attributes/links if isRecording.
Move method to export the attributes list to attributeMap.
* run make precommit to update mod files.- Loading branch information
1 parent
eb3b31e
commit 3495d74
Showing
12 changed files
with
99 additions
and
75 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| // Copyright 2019, OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package trace | ||
|
|
||
| import ( | ||
| "container/list" | ||
|
|
||
| "go.opentelemetry.io/otel/api/core" | ||
| "go.opentelemetry.io/otel/sdk/export/trace" | ||
| ) | ||
|
|
||
| // attributesMap is a capped map of attributes, holding the most recent attributes. | ||
| // Eviction is done via a LRU method, the oldest entry is removed to create room for a new entry. | ||
| // Updates are allowed and refreshes the usage of the key. | ||
| // | ||
| // This is based from https://github.com/hashicorp/golang-lru/blob/master/simplelru/lru.go | ||
| // With a subset of the its operations and specific for holding core.KeyValue | ||
| type attributesMap struct { | ||
| attributes map[core.Key]*list.Element | ||
| evictList *list.List | ||
| droppedCount int | ||
| capacity int | ||
| } | ||
|
|
||
| func newAttributesMap(capacity int) *attributesMap { | ||
| lm := &attributesMap{ | ||
| attributes: make(map[core.Key]*list.Element), | ||
| evictList: list.New(), | ||
| capacity: capacity, | ||
| } | ||
| return lm | ||
| } | ||
|
|
||
| func (am *attributesMap) add(kv core.KeyValue) { | ||
| // Check for existing item | ||
| if ent, ok := am.attributes[kv.Key]; ok { | ||
| am.evictList.MoveToFront(ent) | ||
| ent.Value = &kv | ||
| return | ||
| } | ||
|
|
||
| // Add new item | ||
| entry := am.evictList.PushFront(&kv) | ||
| am.attributes[kv.Key] = entry | ||
|
|
||
| // Verify size not exceeded | ||
| if am.evictList.Len() > am.capacity { | ||
| am.removeOldest() | ||
| am.droppedCount++ | ||
| } | ||
| } | ||
|
|
||
| func (am *attributesMap) toSpanData(sd *trace.SpanData) { | ||
| len := am.evictList.Len() | ||
| if len == 0 { | ||
| return | ||
| } | ||
|
|
||
| attributes := make([]core.KeyValue, 0, len) | ||
| for ent := am.evictList.Back(); ent != nil; ent = ent.Prev() { | ||
| if value, ok := ent.Value.(*core.KeyValue); ok { | ||
| attributes = append(attributes, *value) | ||
| } | ||
| } | ||
|
|
||
| sd.Attributes = attributes | ||
| sd.DroppedAttributeCount = am.droppedCount | ||
| } | ||
|
|
||
| // removeOldest removes the oldest item from the cache. | ||
| func (am *attributesMap) removeOldest() { | ||
| ent := am.evictList.Back() | ||
| if ent != nil { | ||
| am.evictList.Remove(ent) | ||
| kv := ent.Value.(*core.KeyValue) | ||
| delete(am.attributes, kv.Key) | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters