Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Trait tab, datasets are not displayed #454

Closed
Don-Isdale opened this issue Dec 5, 2024 · 1 comment
Closed

In the Trait tab, datasets are not displayed #454

Don-Isdale opened this issue Dec 5, 2024 · 1 comment
Assignees

Comments

@Don-Isdale
Copy link
Collaborator

Don-Isdale commented Dec 5, 2024

Description

The Trait tab is displaying the Trait names, but no datasets are displayed within the traits when the traits are expanded.
This means that users are not able to select datasets:chromosomes to view based on the traits of the features in the datasets.

This display was OK in earlier releases.


Investigation and Estimation

After an initial investigation, the problem is localised to a library used by the Dataset Explorer, and this narrows down the estimated effort to fix the issue to 2-8H.

@Don-Isdale Don-Isdale self-assigned this Dec 5, 2024
Don-Isdale added a commit that referenced this issue Dec 10, 2024
 ... this was broken by #370 which included d3 update; b7e2ae2 converted
from d3.nest() to d3.group(), but additional changes were required.
 d3.nest() result is [{key, values}, ..]
 d3.group() result is Map key->value
(related note in manage-explorer.js : parentAndScope()).
Instead of maintaining the nested structure, this commit changes nested to grouped.

Closes #454

grouping.js :
 in blocksParentAndScope2() and throughout : rename nested to grouped,
 including these 2 function names :
  fromNestedMulti() -> fromGroupedMulti()
  fromNestedParentAndScope() -> fromGroupedParentAndScope()

 fromGroupedMulti() :
  change recursion check to : values instanceof Map.
  if (typeof values !== object) don't call levelMeta.set(values ) (WeakMap.set() only valid for object value).
@Don-Isdale
Copy link
Collaborator Author

Changes Implemented

dbfcea4 fix display of blocks in the Trait tab

Tested OK on local

Screenshot from 2024-12-10 16-52-57
Screenshot from 2024-12-10 16-53-07
Screenshot from 2024-12-10 16-55-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant