Add header option to SjppAntTask

[alfonsodelavega]

This pull request adds a header optional parameter to the sjpp ant task completing #1 .

As there is currently some functionality around the GENERATED line that is unknown for me at the moment (e.g. see this), any header is added after the generic "this file has been autogenerated..." line.

I have used it to add license headers to auto-generated PlantUML codebases. I'll submit a PR to the plantuml repository next.

[alfonsodelavega]

I've detected a bug due to the added header being removed, working on it.

[alfonsodelavega]

It is finished and ready for review now.

[arnaudroques]

Sounds good!
I've sent you an invitation, so you could make a new release by yourself (if that's fine for you).
We should also probably remove sjpp.jar from plantuml repository and instead modify the CI/CD of PlantUML so that it fetches sjpp from an official release here.
Any idea on how to do that? :-)

[alfonsodelavega]

Hi,

I've sent you an invitation, so you could make a new release by yourself (if that's fine for you).

Github releases/actions are not my strong suit, but this seems like a good opportunity to learn. Any pointers?

We should also probably remove sjpp.jar from plantuml repository and instead modify the CI/CD of PlantUML so that it fetches sjpp from an official release here. Any idea on how to do that? :-)

That sounds like a great idea that I have no clue how to do :D. I'll have a look, I suppose Github Actions would allow doing some sort of clever wget / curl to fetch the latest release.

[arnaudroques]

Github releases/actions are not my strong suit, but this seems like a good opportunity to learn. Any pointers?

Not our strong suit either :-) We have set up a minimal CI/CD there.
However, here some links that helped us:

• https://birtony.medium.com/setting-up-automated-release-workflow-with-github-actions-628dbca2446e
• https://localheinz.com/articles/2022/01/24/creating-releases-with-github-actions/
• https://everhour.com/blog/github-actions-tutorial/

Frankly, it's not that easy to use Github releases/action.
We can still make it manually this time (like we did for 0.0.3).
You can even do it manually if you want.

But as you said, this is a opportunity to learn (for us also!).
sjps is really a very simple project but what we learn here can be use for the larger PlantUML core project.

We should also probably remove sjpp.jar from plantuml repository and instead modify the CI/CD of PlantUML so that it fetches sjpp from an official release here. Any idea on how to do that? :-)

That sounds like a great idea that I have no clue how to do :D. I'll have a look, I suppose Github Actions would allow doing some sort of clever wget / curl to fetch the latest release.

Yes, I think a wget/curl to https://github.com/plantuml/sjpp/releases/download/0.0.3/sjpp.jar (or to the future 0.0.4) is possible.

However, no pressure here: we can still manually import the new sjpp.jar file in the repository, even if this is quite dirty :-)

Really, it's up to you: Open Source must be a pleasure!