Default to not writing a pidfile unless daemonized #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plashchynski
added a commit
that referenced
this pull request
Apr 2, 2015
Default to not writing a pidfile unless daemonized
|
@thomasfedb Thank you! |
|
✨ Do you know when your next release is going to be? |
|
@thomasfedb Hopefully on the next week |
|
@thomasfedb We've released a new version that included this and other fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pidfiles are generally only used when you have a daemonized process. In other circumstances they are superfluous and can actually cause issues (e.g. deploying to Heroku with no
tmpdirectory).This PR enables pidfiles by default only when daemonized, although the pidfile can always be explicity enabled.