Await rendered template if neccesary #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest release of jupyterhub made render_template return a coroutine: jupyterhub/jupyterhub@be211a4
So it needs to be awaited now, or else self.write throws an error.
To keep backwards compatibility, I first check of the result is indeed awaitable.
Could also just drop this check and always await it, if assuming the use of the latest version of jupyterhub is fine.