Use --label to set labels #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @TimoRoth for this and the upstream PR!
This sounds like a more robust way 👍 |
Closed
|
@TimoRoth looks like jupyterhub/repo2docker#1097 has been merged. Mind rebasing the PR to grab the latest changes? Which might help fix the CI. Thanks! |
|
For those who want to use this feature, don't forget to pull the latest Thanks again @TimoRoth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on jupyterhub/repo2docker#1097 being merged.
We'd like to use images which are built from custom Dockerfiles, for which --appendix does not work.
The aforementioned PR adds a more generic --label option, and this makes use of it.