Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing tests for JuMP v1.11.1 #81

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

odow
Copy link
Contributor

@odow odow commented May 22, 2023

JuMP recently tweaked how we printed sets: jump-dev/JuMP.jl#3341.

I also took the liberty of adding compat bounds for your test dependencies.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ac6a93) 88.76% compared to head (bcebcfc) 88.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          19       19           
  Lines        2324     2324           
=======================================
  Hits         2063     2063           
  Misses        261      261           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jalving
Copy link
Member

jalving commented May 23, 2023

Great, thanks for updating this @odow!

@jalving jalving merged commit 88d2bb9 into plasmo-dev:main May 23, 2023
@odow odow deleted the od/fix-tests branch May 23, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants