Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aggregate bug #92

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix aggregate bug #92

merged 1 commit into from
Oct 9, 2023

Conversation

jalving
Copy link
Member

@jalving jalving commented Oct 9, 2023

this should fix #76 where aggregating an optigraph to a depth more than 0 failed. we were incorrectly selecting the parent graphs to aggregate into a new optigraph.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/aggregate.jl 92.54% <100.00%> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@jalving jalving merged commit a70d81e into plasmo-dev:main Oct 9, 2023
@jalving jalving deleted the fix-aggregate branch January 19, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aggregate throws an error for some OptiGraphs when max_depth > 0
2 participants