Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin active_material to earlier version #501

Merged

Conversation

alexeyschepin
Copy link

Motivation / Background

v1 version of activeadmin_addons has a dependency on active_material gem. active_material gem had recently a new release that relies on ruby 3.1 built-in methods without setting it in required_ruby_version. That leads the app running on ruby 3.0 to crash.

Detail

It can be fixed if a dependency on active_material had more specific range like (~> 1.5) or (~> 1.5.2)

Additional information

I've also sent a PR to active_material dkniffin/active_material#100

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a concise description of what changed and why.
  • [N/A] Tests are added or updated if you fix a bug or add a feature.
  • [N/A] Documentation has been added or updated if you add a feature or modify an existing one.
  • [N/A] CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature (under the "Unreleased" heading if this is not a version change).
  • My changes don't introduce any linter rule violations.

@rjherrera
Copy link
Member

hey, thanks for the PR, looks good to me

@rjherrera rjherrera merged commit 3ca7e9e into platanus:v1 Sep 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants