Added support for multiple model types to shared.js #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows shared.js to store cache based on type of data, so it can store multiple objects with the same $pk, as long as they are of different types. Most of this code came from @jasonayre in issue platanus#208. Lines 39-41 were added by me to fix a bug where model scopes would get nested after being cached. This way the scope is refreshed every time it is read from the cache.
|
@ldeboer This PR is quite old and out of date. Do you still have any interest in getting it included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows shared.js to store cache based on type of data, so it can store multiple objects with the same $pk, as long as they are of different types. Most of this code came from @jasonayre in issue #208.
Lines 39-41 were added by me to fix a bug where model scopes would get nested after being cached. This way the scope is refreshed every time it is read from the cache.