Merge pull request #1027 from pjkaufman/master

Fix: Undefined Custom Regex Label Causes Error
platers · Feb 28, 2024 · b87f0e2 · b87f0e2
2 parents 59bac09 + d3e1798
commit b87f0e2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/__tests__/rules-runner.test.ts b/__tests__/rules-runner.test.ts
@@ -208,6 +208,22 @@ const customReplaceTestCases: CustomReplaceTestCase[] = [
  <!-- linter-enable -->
  `,
  },
+ { // accounts for https://github.com/platers/obsidian-linter/issues/1025
+ testName: 'A custom replace with an undefined label should still run.',
+ listOfRegexReplacements: [
+ {
+ label: undefined, find: 'lobo', replace: 'hello', flags: 'g',
+ },
+ ],
+ before: dedent`
+ How does this look?
+ Did it stay the same?
+ `,
+ after: dedent`
+ How does this look?
+ Did it stay the same?
+ `,
+ },
 ];
 
 describe('Rules Runner', () => {

diff --git a/src/rules-runner.ts b/src/rules-runner.ts
@@ -186,7 +186,7 @@ export class RulesRunner {
  }
 
  let debugMsg = eachRegex.label;
- if (debugMsg.trim() != '') {
+ if (debugMsg && debugMsg.trim() != '') {
  debugMsg += ':\n';
  }
  debugMsg +=`/${eachRegex.find}/${eachRegex.flags}/${eachRegex.replace}/`;