-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: H1 first letter capitalisation fails #647
Comments
@RhvdG , do you mind giving an example file name? I am guessing it is lowercase, but I am not sure. Does this happen when you run the Linter multiple times? If not, then I am not sure this is a bug since adding the H1 and the capitalization of the first letter of the H1 name does not know about the capitalize header rule. |
@pjkaufman Yes, all lowercase, like |
The rule knows nothing about it, so that would be hard to do. It would only be feasible if the H1 generating rules were set to run before all other regular rules, but after YAML fix rules were applied. |
Instead of running the H1 rules first, I will move the H1 capitalization rule to run at the end of all other rules and see if it fixes the issue you are describing. I believe it will do the trick, but I will need to do some testing to be sure. |
This should be fixed on master and in the next release. I plan to make the release later on today or tomorrow after I add some documentation around adding translation info. Please let us know if this is not fixed on either master or in the next release. |
Describe the Bug
H1 Headers are created from the file name, but the first letter (normal a-z letter) is never capitalised.
How to Reproduce
Run Linter on a file without a H1 header.
Logs don't appear.
Expected Behavior
Capitalised first letter in generated H1 header.
The text was updated successfully, but these errors were encountered: