Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: H1 first letter capitalisation fails #647

Closed
RhvdG opened this issue Mar 12, 2023 · 5 comments · Fixed by #679
Closed

Bug: H1 first letter capitalisation fails #647

RhvdG opened this issue Mar 12, 2023 · 5 comments · Fixed by #679
Assignees
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature reproducible resolution/update-made A change has been made that should resolve this issue or request

Comments

@RhvdG
Copy link

RhvdG commented Mar 12, 2023

Describe the Bug

H1 Headers are created from the file name, but the first letter (normal a-z letter) is never capitalised.

How to Reproduce

Run Linter on a file without a H1 header.

Logs don't appear.

Expected Behavior

Capitalised first letter in generated H1 header.

@RhvdG RhvdG added the bug Something isn't working label Mar 12, 2023
@pjkaufman
Copy link
Collaborator

@RhvdG , do you mind giving an example file name? I am guessing it is lowercase, but I am not sure. Does this happen when you run the Linter multiple times? If not, then I am not sure this is a bug since adding the H1 and the capitalization of the first letter of the H1 name does not know about the capitalize header rule.

@RhvdG
Copy link
Author

RhvdG commented Mar 12, 2023

@pjkaufman Yes, all lowercase, like ervaring.md. I ran the Linter twice to try, and the second time the first letter is capitalised. Perhaps this should somehow happen the when the H1 header is first created from the file name?

@pjkaufman
Copy link
Collaborator

The rule knows nothing about it, so that would be hard to do. It would only be feasible if the H1 generating rules were set to run before all other regular rules, but after YAML fix rules were applied.

@pjkaufman
Copy link
Collaborator

Instead of running the H1 rules first, I will move the H1 capitalization rule to run at the end of all other rules and see if it fixes the issue you are describing. I believe it will do the trick, but I will need to do some testing to be sure.

@pjkaufman
Copy link
Collaborator

This should be fixed on master and in the next release. I plan to make the release later on today or tomorrow after I add some documentation around adding translation info. Please let us know if this is not fixed on either master or in the next release.

@pjkaufman pjkaufman added obsidian Obsidian specific syntax issue or feature resolution/update-made A change has been made that should resolve this issue or request reproducible labels Apr 8, 2023
@pjkaufman pjkaufman self-assigned this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature reproducible resolution/update-made A change has been made that should resolve this issue or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants