Fix: capitalize-headings, yaml-title, yaml-title-alias require two lint passes to resolve #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaml-title needs to run after capitalize-headings since it may be configured to use the first H1 heading as the title value.
yaml-title-alias should run after capitalize-headers and yaml-title since the alias may depend on the H1 header.
|
Hey @tcoliver , thanks for making a PR around this. I will plan on taking a look at it soon. I have not forgotten about this, but I have not made the time to take a look at it and verify that it does indeed work. I just need to double check the logic and we should be good to proceed form there if nothing else pops up. |
|
Glad to be of help! Thank you for all the work on this excellent tool. I'll be looking for ways to contribute again in the future. |
|
I'll look forward to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1130
I moved the yaml-title and yaml-title-alias rules to the runAfterRegularRules method. They immediately follow the capitalize-headings rule.