Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Too many warning inside develop tool #734

Closed
1 of 2 tasks
CaptainVincent opened this issue May 25, 2023 · 9 comments · Fixed by #735
Closed
1 of 2 tasks

Bug: Too many warning inside develop tool #734

CaptainVincent opened this issue May 25, 2023 · 9 comments · Fixed by #735
Assignees
Labels
bug Something isn't working resolution/update-made A change has been made that should resolve this issue or request

Comments

@CaptainVincent
Copy link

Describe the Bug

Error: Component for proper lifecycle management is missing. This is needed to avoid memory leaks when embedded contents register global event handlers. Please let the plugin's author mentioned in the stack trace know.

How to Reproduce

Open develop tool check console

I'm seeing hundreds of these warnings, and I didn't encounter these issues in the previous weeks.

I'm not sure if this is related to conflicts with other plugins or obsidian version,

but simply (a b testing) disabling this plugin could resolves the issue.

Expected Behavior

Remove unnecessary warnings.

Screenshots

warning

Device

  • Desktop - Mac M2
  • Mobile

Additional Context

About Obsidian Version 1.3.3 (Installer 1.2.7)
Linter 1.15.0

@CaptainVincent CaptainVincent added the bug Something isn't working label May 25, 2023
@pjkaufman
Copy link
Collaborator

@CaptainVincent , have you verified that disabling the Linter causes the warnings to go away?

I am asking because I did not see these warnings yesterday, but I might not be on the latest version of Obsidian.

@pjkaufman
Copy link
Collaborator

This probably has to do with the latest update and memory leaks they said they figured out were happening due to plugins. I am not sure that the Linter is causing any memory leaks, but I will gladly apply the fix to the plugin if the Linter does get the warnings.

@pjkaufman
Copy link
Collaborator

I believe I have a fix for this. It should go out with the next release which will hopefully be a patch today or tomorrow, but we will see how that turns out.

@pjkaufman
Copy link
Collaborator

Also note that I am not seeing the same behavior as you are. I am just seeing the warning logged once for the Linter which likely means that other plugins are also having this issue.

@pjkaufman
Copy link
Collaborator

Looks like the fix I wanted to use is not something I am supposed to use. I am waiting on feedback on how to do what has been requested with the new update, but so far it seems like I don't have a good way of fixing this at this time.

@pjkaufman
Copy link
Collaborator

This issue should be fixed with the next release. Thanks for reporting it.

If the issue persists after the next release, please turn off a plugins except the Linter and verify that this is an issue specific to the Linter as there seem to be a decent amount of plugins that have this warning.

@pjkaufman pjkaufman added the resolution/update-made A change has been made that should resolve this issue or request label May 25, 2023
@pjkaufman pjkaufman self-assigned this May 25, 2023
@CaptainVincent
Copy link
Author

Sorry for the late response. I apologize for not seeing your reply earlier. This issue could be resolved on my local end by disabling the extension (clearing all warnings). However, I understand that you mentioned experiencing this phenomenon only once, so it cannot be ruled out that it was triggered by another extension recursively. Thank you very much for your quick fix, and I look forward to the next release. THANK U 💯

@pjkaufman
Copy link
Collaborator

You should be able to update to version 1.15.1, @CaptainVincent and the issue should be resolved for the Linter.

@CaptainVincent
Copy link
Author

@pjkaufman Great! It's fixed now. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolution/update-made A change has been made that should resolve this issue or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants