Make Linter Compliant with Component Usage for MarkdownRenderer #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734
There was a change in the most recent update of Obsidian that helps prevent memory leaks and other issues. It added a warning for not using a component when using
renderMarkdown. To make sure we are compliant and prevent the risk of a memory leak, a component (a settings tab component) is used to make sure things are loaded and unloaded properly for UI components which are used form the settings page.Changes Made:
renderMarkdownto now get a the component to control the existence of the markdown onesbuildto make sure it ignored the proper import for generating docs.