Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Empty Lines Around Blockquotes Can Cause Problems with Nested Callouts with a Single Blank Line Between Them #812

Closed
1 task done
alitekdemir opened this issue Jul 20, 2023 · 4 comments · Fixed by #817
Assignees
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature resolution/update-made A change has been made that should resolve this issue or request

Comments

@alitekdemir
Copy link
Contributor

  • Linter v1.17.0

Describe the Bug

I showed it in the video. Actually I was thinking it wouldn't add extra characters. Since I did not see such an explanation in the document, I wanted to report it as an error.

Expected Behavior

shouldn't add extra characters.

i use this sample markdown

> [!multi-column]
>
>> [!note]+ Use Case
>> Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
>> ##### User Case Background
>> Vitae nunc sed velit dignissim sodales. In cursus turpis massa tincidunt dui ut ornare lectus.
>
>> [!warning]+ Resources
>> #### Requirement
>> - Lorem ipsum dolor sit amet
>> - Vitae nunc sed velit dignissim sodales.
>> - In cursus turpis massa tincidunt dui ut ornare lectus.
>
>> [!todo]+
>> - [x] Define Use Case
>> - [ ] Craft User Story
>> - [ ] Develop draft sketches

Screenshots

Obsidian_2023-07-20_15-39-40.mp4
@alitekdemir alitekdemir added the bug Something isn't working label Jul 20, 2023
@pjkaufman
Copy link
Collaborator

@alitekdemir , I am not sure this is a bug. The Linter knows almost nothing about callouts so they are treated as blockquotes. In this case, the blank line is upgraded to be a doubly nested blank line because the blank is between 2 doubly nested blockquotes.

I can see how this would cause problems for callouts, but it should have 0 affect on true blockquotes.

I may need to add some consideration for callouts, but I will have to look more into this.

@pjkaufman pjkaufman changed the title Bug: Blockquotes add extra ">" Bug: Empty Lines Around Blockquotes Can Cause Problems with Nested Callouts with a Single Blank Line Between Them Jul 20, 2023
@pjkaufman
Copy link
Collaborator

I believe I have a fix for this. I will push it up and barring any formatting issues caused when I test before the next release, it will go out with the next release.

@pjkaufman pjkaufman added the obsidian Obsidian specific syntax issue or feature label Jul 23, 2023
@pjkaufman pjkaufman self-assigned this Jul 23, 2023
@pjkaufman pjkaufman added the resolution/update-made A change has been made that should resolve this issue or request label Jul 23, 2023
@pjkaufman
Copy link
Collaborator

Hopefully this fix will not cause other issues to pop up.

@alitekdemir
Copy link
Contributor Author

Thank you very much for your prompt attention. And my heartfelt congratulations to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature resolution/update-made A change has been made that should resolve this issue or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants