-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Empty Lines Around Code Fences
can cause problems with nested callouts
#1074
Comments
In addition, is seems that if you add headers to the multi-columns it will break both
|
I believe I have a partial solution, but it looks like it does not properly account for several scenarios. I will need to spend some more time working on it to account for the remaining scenarios. I have decided that I will try not to join two blockquotes/callouts if one of the adjoining blockquotes/callouts is part of a code block. |
Looks like that approach does not always work. I will need to handle a couple more scenarios to make sure things are handled correctly. |
I think I have the issue ironed out. However I do want to account for a scenario yet. Once that is handled, I can get this change merged. |
The other scenario is a lot more complex, so I will leave it be until we need the added complexity. I will create a PR for the fix for this. |
This should be fixed on master and go out with the next release. Please let us know if the issue not fixed in either. I may have time to make a release today, but it may have to go out later this week. |
Describe the Bug
I'm on version 1.23.2 and am experiencing what seems to be a similar issue to #812. However, in my case, the problem is caused by the setting
Empty Line Around Code Fences [x]
as opposed toEmpty Line Around Blockquotes [x]
.Like the other issue the linter will insert an extra angle bracket between the two child callouts.
How to Reproduce
While messing around with this I found no tweaks to the blockquote settings had any noticeable changes.
So in order to reproduce this I assume you just need to enable
Empty Line Around Code Fences
and trigger the linter with the following snippet.Debug logs
data.json
Expected Behavior
The offending snippet contains code-blocks so it make since why that setting might have some issues,
but I'm not so sure that it should occur in either case when aforementioned setting is enabled or disable.
Device
The text was updated successfully, but these errors were encountered: