Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Blockquotes Joined When Code Block Ends/Starts Two Same Level Blockquotes #1118

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

pjkaufman
Copy link
Collaborator

Fixes #1074

There was a scenario where if a blockquote was next to another one, it was getting joined if there was a table in it. This was not desired and could cause funky results, so it has been updated to not do this where possible.

Changse Made:

  • Added tests for the scenarios in question
  • Updated the logic to make sure a blockquote which starts or ends in a code block is not joined with the next blockqoute

@pjkaufman pjkaufman added the bug Something isn't working label Jul 7, 2024
@pjkaufman pjkaufman self-assigned this Jul 7, 2024
@pjkaufman pjkaufman merged commit 4b978d0 into platers:master Jul 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Empty Lines Around Code Fences can cause problems with nested callouts
1 participant