Support Obsidian-style comment for inline linter toggle #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting in the effort to add this change @sevmonster . It looks pretty simple and good so far. I think the only concerns I have right now are that no UTs were added and that the docs would need updating to include the syntax reference to this new syntax. The three tests shown by this search should have a duplicated test for the new syntax. I can update the docs or if you want to the source for the docs in question is located here. The only thing I would like to see added are the UTs for this PR, but if you want to add the docs change as well, that is fine with me. |
|
I went ahead and made the two requested additions. Assuming UTs pass, I will go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1121