Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Format Tags in YAML Should Only Match tag or tags YAML Value. #1157

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

pjkaufman
Copy link
Collaborator

Fixes #1155

There was an issue where Format Tags in YAML was matching on more than just the value for the tag or tags key if that key was directly or shortly thereafter followed by a value that had a # in it. Updating the regex to better match how regex values are identified elsewhere seems to fix this issue.

Changes Made:

  • Added a UT for the scenario in question
  • Updated regex to match more closely what is done to get a YAML key's value elsewhere

@pjkaufman pjkaufman added the bug Something isn't working label Aug 31, 2024
@pjkaufman pjkaufman self-assigned this Aug 31, 2024
@pjkaufman pjkaufman merged commit f5d11c8 into platers:master Aug 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Linter setting breaks 'Share Note' plugin
1 participant