Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and Update Integration Tests #1168

Merged
merged 9 commits into from
Sep 13, 2024

Conversation

pjkaufman
Copy link
Collaborator

Adds better integration tests than what are currently present in a couple of ways:

  • Adds the ability to have a file in the test vault that corresponds to a test file that has the expected output of running a rule against it
  • Adds the ability for the person running the integration test to know the results of the tests via a notice instead of just relying on the console
  • Adds the ability for the user to know if for some reason not all normal tests are finished before attempting to run the cache update tests
  • Adds the ability for the user to know if the tests take too long to run normally as there is now a timeout that when exceeded is used to determine if a test has not completed in that time

Beyond just fixing this one issue, it also adds some other changes:

  • Removes some console logs that were meant to be used for debugging a different issue
  • Awaits or uses void for all async functions to make it clear what is being done where
  • Added some more ITs
  • Added some linting rules to be aware of promises that are not being awaited

@pjkaufman pjkaufman self-assigned this Sep 13, 2024
@pjkaufman pjkaufman changed the title Add Update Integration Tests Add and Update Integration Tests Sep 13, 2024
@pjkaufman pjkaufman merged commit 07e1ea4 into platers:master Sep 13, 2024
1 check passed
@pjkaufman pjkaufman deleted the new-integration-tests branch September 13, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant