Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue with Yaml FrontMatter Including More Than Initial Frontmatter #204

Merged
merged 5 commits into from
May 20, 2022

Conversation

pjkaufman
Copy link
Collaborator

@platers

Fixes #176

Changes Made:

  • Updated yaml regex identification to not allow --- in it
  • Added a test to make sure this issue is not reintroduced by accident

Please let me know if it is fine to not do a peer review on these PRs. I come from a background where peer-reviews are required before merging.

…t folder (the underlying code duplicates the confirmation modal code and slightly modifies the linting rule for all files for just the folder)
…t end up going past the end of the yaml frontmatter with what we consider to be the yaml frontmatter.
@pjkaufman pjkaufman added the bug Something isn't working label May 20, 2022
@pjkaufman pjkaufman self-assigned this May 20, 2022
@platers
Copy link
Owner

platers commented May 20, 2022

Feel free to merge in these smaller PR's without review. I'll take a look at the larger ones with more structural changes.

@pjkaufman
Copy link
Collaborator Author

Sounds good. I will merge it in then.

@pjkaufman pjkaufman merged commit 85abb9a into platers:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YAMLException$1 reason: 'end of the stream or a document separator is expected at line x, column x:'
2 participants