Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Logic and Add Fenced Code Block Empty Lines #285

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

pjkaufman
Copy link
Collaborator

Relates to #32

Did some code cleanup with regards to values that come from the window making them available for Typescript to validate information around. Also added a new rule for fenced code blocks getting empty lines around them. Replaced custom normalize path with normalize path from obsidian.

Changes Made:

  • Added a window interface to allow for Typescript to recognize moment and a command to help with not needing to do any casts (I am working on the casts to any and removing them)
  • Replaced normalize path function with the one from Obsidian to cut down on code creation since we can use the provided API
  • Added a new rule for adding an empty line around fenced code blocks

@pjkaufman pjkaufman added markdown General Markdown or Markdown related issue or feature code cleanup labels Jul 14, 2022
@pjkaufman pjkaufman self-assigned this Jul 14, 2022
@pjkaufman pjkaufman merged commit dcfb808 into platers:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup markdown General Markdown or Markdown related issue or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant