Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Language Support for Rule Options that Come from Actual Rules and not General Settings #648

Merged
merged 6 commits into from
Mar 14, 2023

Conversation

pjkaufman
Copy link
Collaborator

Relates to #608

I need to make one more pass at this and just make sure things like fine. I know a couple of variables will likely be renamed, but I am not sure what else will get changed when I make that second pass later on this week.

pjkaufman and others added 2 commits March 12, 2023 18:47
…nguage key text pulled at runtime as requested. This allows for rules to be in more languages than just English
@pjkaufman pjkaufman added the bug Something isn't working label Mar 12, 2023
@pjkaufman pjkaufman self-assigned this Mar 12, 2023
@pjkaufman pjkaufman marked this pull request as ready for review March 14, 2023 22:34
@pjkaufman pjkaufman merged commit 0476ab0 into platers:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant