Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Blockquotes Getting Merged when an Empty Line is Between Them #672

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Fix Blockquotes Getting Merged when an Empty Line is Between Them #672

merged 3 commits into from
Apr 7, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #668

Changes Made:

  • Added tests to make sure that blockquotes one or more empty lines between them will not get merged
  • Updated the logic to make sure that a blockquote that ends with a blank line at the end will get a blank line as its ending or starting empty line
  • Fixed a typo in a comment
  • Removed an unused param for getting the empty line

@pjkaufman pjkaufman self-assigned this Apr 7, 2023
@pjkaufman pjkaufman added bug Something isn't working markdown General Markdown or Markdown related issue or feature labels Apr 7, 2023
@pjkaufman pjkaufman merged commit ab6ce29 into platers:master Apr 7, 2023
@pjkaufman pjkaufman mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Consecutive Blockquotes Merging
1 participant
@pjkaufman