Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Erroneous Empty Line Added to Math Block End in Callout/Blockquote #678

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Fix Erroneous Empty Line Added to Math Block End in Callout/Blockquote #678

merged 1 commit into from
Apr 8, 2023

Conversation

pjkaufman
Copy link
Collaborator

Relates to #597

Changes Made:

  • Added a test for a scenario I found where a blank line was always being added for a blockqupte/callout that had a math block in it
  • Updated the logic in the ending math block check to make sure that if math block is in a blockquote/callout then it should only add a blank line if the start of the ending line is not just the blockquote indicators and then the math block indicators

@pjkaufman
fixed an issue with moving code block indicators to their own lines w…
1866e71 
…hen in a blockquote/callout and a blank line was always added even when not needed
@pjkaufman pjkaufman added bug Something isn't working math Relates to math support in markdown labels Apr 8, 2023
@pjkaufman pjkaufman self-assigned this Apr 8, 2023
@pjkaufman pjkaufman merged commit 37c544a into platers:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working math Relates to math support in markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pjkaufman