Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Table Matching Logic and Add Paragraph Blank Lines Example #706

Merged
merged 3 commits into from
May 5, 2023
Merged

Fix Table Matching Logic and Add Paragraph Blank Lines Example #706

merged 3 commits into from
May 5, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #704

Changes Made:

  • Added UTs for paragraph blank lines and table matching for the scenario with an empty list item proceeded by a blank line
  • Updated table recognition of invalid tables to be more generic just checking that the first or second line of the table has a pipe in it otherwise it cannot be a table

pjkaufman and others added 2 commits May 5, 2023 16:28
@pjkaufman
Updated the table matching logic to not match empty list items precee…
f864946 
…ded by an empty line, added the corresponding tests, and added a new example to paragraph blank lines to make it so it is a little clearer how it works
@pjkaufman
Merge branch 'platers:master' into master
a0e6711
@pjkaufman pjkaufman added bug Something isn't working markdown General Markdown or Markdown related issue or feature labels May 5, 2023
@pjkaufman pjkaufman merged commit ac3bd83 into platers:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Unexpected blank line.
1 participant
@pjkaufman