Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YAML Title Alias Not Escaping Commas #720

Merged
merged 3 commits into from
May 14, 2023
Merged

Fix YAML Title Alias Not Escaping Commas #720

merged 3 commits into from
May 14, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #630

Changes Made:

  • Added tests for the scenarios where headers with a comma should be escaped due to comma delimited aliases being used
  • Added a test to make sure multi-line arrays were not getting escaped by the new logic as well
  • Updated the logic to force the escaping of a value if the title has a comma and the alias style uses commas to delimit the alias list

@pjkaufman pjkaufman added bug Something isn't working yaml YAML related issues or features labels May 14, 2023
@pjkaufman pjkaufman self-assigned this May 14, 2023
@pjkaufman pjkaufman merged commit ad1a792 into platers:master May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working yaml YAML related issues or features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: YAML Title Alias does not escape commas
1 participant
@pjkaufman