Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Checklists Account for Custom Checklist Markers #749

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #748

Changes Made:

  • Removed an unnecessary and incorrect comment
  • Consolidated a lot of the checklist regex to be built on plugin load
    • This helps with performance so we are not building regex values more than 1 time when the value will be the same over and over again
    • This also allows for some uniformity on how checklists are found and matched as you can use a template and just have it reuse the value for the checklist box
  • Broke apart and added a couple of examples to show that things were working
  • Went ahead and fixed the wording on a couple of tests that I noticed was wrong
  • Replaced old regex uses for checklists with the new regex that is built on load

@pjkaufman pjkaufman added enhancement New feature or request code cleanup labels Jun 3, 2023
@pjkaufman pjkaufman self-assigned this Jun 3, 2023
@pjkaufman pjkaufman merged commit 5cd5b2f into platers:master Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Update Checklist Regex to Allow Custom Checklists
1 participant