fix npm dependencies issues #756
Conversation
unist-util-visit is src/utils/mdast.ts and @jest/types is need for jest
| @@ -63,6 +64,7 @@ | |||
| "micromark-util-combine-extensions": "^1.0.0", | |||
| "moment-parseformat": "^4.0.0", | |||
| "quick-lru": "^6.1.1", | |||
| "ts-dedent": "^2.2.0" | |||
| "ts-dedent": "^2.2.0", | |||
| "unist-util-visit": "^4.1.2" | |||
There was a problem hiding this comment.
This should already be included by another package. I say that because it has run just fine up until now. I do not mind adding it, but I am not sure why we would need to add it now.
There was a problem hiding this comment.
It could be that these changes were somehow included globally for me and that is why they work for me. But they seem to work in main.js for the plugin. Could you let us know what editor you used @qazxcdswe123 that needed these npm packages to work?
Typically I use VSCode or NeoVim. So it could be that one of them already accounted for the discrepancy in dependencies.
There was a problem hiding this comment.
This is what I get after removing this two dependencies, the build/test can't be run.
I use neovim and the lsp also compliant about the import.
There was a problem hiding this comment.
Gotcha. It should be fine to merge this then. My node modules locally must have kept those values somehow.
There was a problem hiding this comment.
Nevermind I forget to copy the css file
BTW, mayble a different version of this dependency is needed since the UI somehow broke for me 😢 . Don't know if it is related to this but the UI looks like this, the button and search wont work.
I also tried some other version the UI is somehow still broken
unist-util-visit is
src/utils/mdast.tsand @jest/types is need for jestI'm not sure this is intentional or by accident, but I need this two dependencies to work.
Not sure if this is needed. Feel free to close it.