Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QPS changes #58

Merged
merged 1 commit into from
Sep 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions constants/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,15 @@ var CNIPluginsFilename = fmt.Sprintf("cni-plugins-amd64-%s.tgz", CNIVersion)

const (
// TODO(dlipovetsky) Move fields to configuration
KubeletFailSwapOn = false
KubeletMaxPods = 500
KubeletFailSwapOn = false
KubeletMaxPods = 500
KubeletKubeAPIQPS = 20
KubeletKubeAPIBurst = 40

NodeadmKubeletSystemdDropinFilename = "20-nodeadm.conf"
NodeadmKubeletSystemdDropinTemplate = `[Service]
Environment="KUBELET_DNS_ARGS=--cluster-dns={{ .ClusterDNS }} --cluster-domain={{ .ClusterDomain }}"
Environment="KUBELET_EXTRA_ARGS=--max-pods={{ .MaxPods }} --fail-swap-on={{ .FailSwapOn }} --hostname-override={{ .HostnameOverride }}"
Environment="KUBELET_EXTRA_ARGS=--max-pods={{ .MaxPods }} --fail-swap-on={{ .FailSwapOn }} --hostname-override={{ .HostnameOverride }} --kube-api-qps={{ .KubeAPIQPS }} --kube-api-burst={{ .KubeAPIBurst }}"
`
)

Expand Down
4 changes: 4 additions & 0 deletions utils/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,16 @@ func placeAndModifyNodeadmKubeletSystemdDropin(netConfig apis.Networking) {
ClusterDNS string
ClusterDomain string
HostnameOverride string
KubeAPIQPS int
KubeAPIBurst int
}{
FailSwapOn: constants.KubeletFailSwapOn,
MaxPods: constants.KubeletMaxPods,
ClusterDNS: dnsIP.String(),
ClusterDomain: netConfig.DNSDomain,
HostnameOverride: hostnameOverride,
KubeAPIQPS: constants.KubeletKubeAPIQPS,
KubeAPIBurst: constants.KubeletKubeAPIBurst,
}

writeTemplateIntoFile(constants.NodeadmKubeletSystemdDropinTemplate, "nodeadm-kubelet-systemd-dropin", confFile, data)
Expand Down