-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PCD-157] Add RunWithProgressStatus executor to visualise the progress #390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets not make any changes to the go mod file, if possible
Few changes may require like we are using an external libs for progress bar so it has to include. |
we can reduce the version and it should still work I think |
b7ab7aa
to
35fae32
Compare
…e implimentation is in todo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
ISSUE(S):
PCD-157 cloud-ctl show the status for hostagent installation process
SUMMARY
During the process of downloading and installation of Hostagent only the spinner keeps rotating for a long time until the installation completes. Improvements are made to visualise the continuous progress of the competed stated, bettering the user experience.
ISSUE TYPE
New feature (non-breaking change which adds functionality)
IMPACTED FEATURES/COMPONENTS:
cloud-ctl, pf9ctl
TESTING DONE
Manual
Manual
Reference PR (cloud-ctl): https://github.com/platform9/cloud-ctl/pull/16
Done testing of the same code in cloud-ctl
Reviewers