Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PCD-157] Add RunWithProgressStatus executor to visualise the progress #390

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

prathamesh-PF9
Copy link
Contributor

@prathamesh-PF9 prathamesh-PF9 commented Oct 24, 2024

ISSUE(S):

PCD-157 cloud-ctl show the status for hostagent installation process

SUMMARY

During the process of downloading and installation of Hostagent only the spinner keeps rotating for a long time until the installation completes. Improvements are made to visualise the continuous progress of the competed stated, bettering the user experience.

ISSUE TYPE

New feature (non-breaking change which adds functionality)

IMPACTED FEATURES/COMPONENTS:

cloud-ctl, pf9ctl

TESTING DONE

Manual

Manual

Reference PR (cloud-ctl): https://github.com/platform9/cloud-ctl/pull/16
Done testing of the same code in cloud-ctl

Reviewers

Copy link

@NeelavaChatterjee NeelavaChatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not make any changes to the go mod file, if possible

@prathamesh-PF9
Copy link
Contributor Author

lets not make any changes to the go mod file, if possible

Few changes may require like we are using an external libs for progress bar so it has to include.

@NeelavaChatterjee
Copy link

we can reduce the version and it should still work I think

@prathamesh-PF9 prathamesh-PF9 changed the title Private/prathamesh/pcd 157 [PCD-157] Add RunWithProgressStatus executor to visualise the progress Oct 24, 2024
Copy link

@NeelavaChatterjee NeelavaChatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@psarwate psarwate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@NeelavaChatterjee
Copy link

/lgtm

@prathamesh-PF9 prathamesh-PF9 merged commit 4646d4a into master Oct 25, 2024
4 checks passed
@prathamesh-PF9 prathamesh-PF9 deleted the private/prathamesh/PCD-157 branch October 25, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants