Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node delete fails if nodeadm not present in /opt/bin #42

Open
puneetguptanitj opened this issue Aug 10, 2018 · 2 comments
Open

Node delete fails if nodeadm not present in /opt/bin #42

puneetguptanitj opened this issue Aug 10, 2018 · 2 comments

Comments

@puneetguptanitj
Copy link
Contributor

Deletion of node fails if the nodeadm binary is not present in /opt/bin. It should fetch the correct binary from the cache

puneetguptanitj added a commit that referenced this issue Aug 10, 2018
@sarun87
Copy link
Contributor

sarun87 commented Aug 10, 2018

I have a concern here. A machine should be part of the k8s cluster to begin with for deletion operation and that would mean the right binaries had been placed in /opt/bin. Should we be fetching binaries for deletion at all? I mean, do we want to fix this?

@puneetguptanitj
Copy link
Contributor Author

Hi Arun, yeah ideally those binaries should still be there with the right versions from the last create operation. This is to just to make sure that it is the case. The operation would be a no op if the required binary is already there

puneetguptanitj added a commit that referenced this issue Sep 5, 2018
* Fixes issue #42

* code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants