Fix occasional test flakiness #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is going to break many people when using this. I'd recommend we publish a fork of the mistral client without the monkey patching. It does not look like a lot of code: https://github.com/mistralai/client-js/blob/main/src/client.js. |
|
Can you create the fork repo and I'll open the same pr to it? |
|
Closing, will open pr replacing the Mistral client w/ the Platformatic fork once platformatic/mistral-client#2 is merged and published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mistral client replaces
globalThis.fetchwithnode-fetch. Made a pr in their repo (mistralai/client-js#60) with a proper fix, but in the meantime this should work