Do not include occupied bootloader space in maximum_size #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default maximum_size field should instead reflect the total amount of flash memory the microcontroller has regardless if the user has loaded a bootloader or not.
|
@valeros does it look OK? Anything you want me to change? |
|
All good, many thanks! |
DerAndere1
added a commit
to DerAndere1/Marlin
that referenced
this pull request
Aug 25, 2021
And allow melzi_optiboot for Anet V1.0 board with optiboot. Note: Since platformio/platform-atmelavr#217 , all envs that are intended to be used with a bootloader should define board_upload.maximum_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default maximum_size field should instead reflect the total amount of flash memory the microcontroller has regardless if the user has loaded a bootloader or not. #207 related.
The actual bootloader size (512 or 1024 bytes depending on target) should instead be subtracted from
maximum_sizeifboard_hardware.uart != no_bootloader