Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for P1AM-100 #180

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

NeoGaius
Copy link

Hi,

This adds the support for the P1AM-100 board which is based on the SAMD21. Very similar to the mkrzero.

Information about the hardware can be found here: https://github.com/facts-engineering/P1AM

Is there anything else required to implement this?

Resolves issues #98, #111, and #173

Best regards,
NeoGaius

@Ragiton
Copy link

Ragiton commented Jun 14, 2023

At this point the core should probably be added too since @AdamCummick added Serial2 support to the P1AMCore recently.

Here is a link to the core: https://github.com/facts-engineering/P1AMCore

Is this something you are still able to work on @NeoGaius?

I'm just getting started with using the P1AM with PlatformIO and it would be very nice to have the board supported off the shelf.

Thanks,
Ragiton

@patrickwasp
Copy link

@Ragiton what's issues are you having with https://registry.platformio.org/libraries/facts-engineering/P1AM?

@Ragiton
Copy link

Ragiton commented Jul 7, 2023

@Ragiton what's issues are you having with https://registry.platformio.org/libraries/facts-engineering/P1AM?

@patrickwasp I'm not having issues with the library you mention.

https://registry.platformio.org/libraries/facts-engineering/P1AM_Serial doesn't compile because it can't find Serial2. Serial2 doesn't exist on the mkrzero but it was added to the core here: https://github.com/facts-engineering/P1AMCore

from what I understand, the custom P1AMCore would need to be added for this board to work with the P1AM_Serial library

@patrickwasp
Copy link

is that what's holding back from this pull request being merged? @ivankravets @valeros, can you please provide feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants