Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ESP32-S3-WROOM-1-N16R8 #1383

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions boards/esp32-s3-wroom-1-n16r8.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"build": {
"arduino": {
"ldscript": "esp32s3_out.ld",
"memory_type": "qio_opi",
"partitions": "default_16MB.csv"
},
"core": "esp32",
"extra_flags": [
"-DBOARD_HAS_PSRAM",
"-DARDUINO_ESP32_S3_N16R8",
"-DARDUINO_USB_MODE=1",
"-DARDUINO_USB_CDC_ON_BOOT=1",
Copy link

@chrBrd chrBrd Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DARDUINO_USB_CDC_ON_BOOT=1 probably shouldn't be enabled at this level, but in platformio.ini if it's needed.

I'm using this chip on an ESP32-S3-DevKitC-1. If this flag is included then I have to hold down the 'Boot' button and press 'Reset' every time I want to reflash. If this flag is removed then I can just 'Upload and Monitor' as normal.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DARDUINO_USB_CDC_ON_BOOT=1 probably shouldn't be enabled at this level, but in platform.io if it's needed.

Same for -DARDUINO_USB_MODE=1 !

"-DARDUINO_RUNNING_CORE=1",
"-DARDUINO_EVENT_RUNNING_CORE=1"
],
"f_cpu": "240000000L",
"f_flash": "80000000L",
"flash_mode": "qio",
"hwids": [
[
"0x303A",
"0x1001"
]
],
"mcu": "esp32s3",
"variant": "esp32_s3_wroom_1_n16r8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this board file in my own projects let #include <Arduino.h> lead to this error:
framework-arduinoespressif32/cores/esp32/esp32-hal-gpio.h:29:10: fatal error: pins_arduino.h: No such file or directory.

If I replace the variant name esp32_s3_wroom_1_n16r8 by esp32s3, my projects compile!

},
"connectivity": [
"bluetooth",
"wifi"
],
"debug": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should include:

    "default_tool": "esp-builtin",
    "onboard_tools": [
      "esp-builtin"
    ],

to enable the built-in debugger.

"default_tool": "esp-builtin",
"onboard_tools": [
"esp-builtin"
],
"openocd_target": "esp32s3.cfg"
},
"frameworks": [
"arduino",
"espidf"
],
"name": "ESP32-S3-WROOM-1-N16R8",
"upload": {
"flash_size": "16MB",
"maximum_ram_size": 8388608,
"maximum_size": 16777216,
"require_upload_port": true,
"speed": 460800
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can safely be set to 921600 bauds.

},
"url": "https://www.espressif.com/sites/default/files/documentation/esp32-s3-wroom-1_wroom-1u_datasheet_en.pdf",
"vendor": "Espressif"
}