Upload Filesystem Image OTA (uploadfsota) fails to provide -s flag to espota

[cregganna]

Hi,

I have found an issue when uploading Filesystems via OTA. The "-s" flag is not supplied to the espota call and thus the OTA fails.

The issue is at:

platform-espressif8266/builder/main.py

Line 311 in bb547ce

if "uploadfs" in COMMAND_LINE_TARGETS:

When running OTA FS updates the Target is "uploadfsota" not "uploadfs".

With the original code I see (Note spiffs is reported as False)

Uploading .pio/build/esp12f_upload_ota/littlefs.bin
21:45:16 [DEBUG]: Options: {'esp_ip': '192.168.101.39', 'host_ip': '0.0.0.0', 'esp_port': 8266, 'host_port': 52607, 'auth': 'XXXXXXXX', 'image': '.pio/build/esp12f_upload_ota/littlefs.bin', 'spiffs': False, 'debug': True, 'progress': True}
21:45:16 [INFO]: Starting on 0.0.0.0:52607
21:45:16 [INFO]: Upload size: 1024000
21:45:16 [INFO]: Sending invitation to: 192.168.101.39
Authenticating...OK
21:45:17 [INFO]: Waiting for device...

Uploading: [                                                            ] 0% 
....
Uploading: [============================================================] 100% Done...

21:45:32 [INFO]: Waiting for result...

21:45:32 [ERROR]: ERROR[10]: 
*** [uploadfsota] Error 1

With the code modified to:

if "uploadfsota" in COMMAND_LINE_TARGETS:

I see (Note spiffs is reported as True)

Uploading .pio/build/esp12f_upload_ota/littlefs.bin
21:48:48 [DEBUG]: Options: {'esp_ip': '192.168.101.39', 'host_ip': '0.0.0.0', 'esp_port': 8266, 'host_port': 20550, 'auth': 'XXXXXXXX', 'image': '.pio/build/esp12f_upload_ota/littlefs.bin', 'spiffs': True, 'debug': True, 'progress': True}
21:48:48 [INFO]: Starting on 0.0.0.0:20550
21:48:48 [INFO]: Upload size: 1024000
21:48:48 [INFO]: Sending invitation to: 192.168.101.39
Authenticating...OK
21:48:49 [INFO]: Waiting for device...

Uploading: [                                                            ] 0% 
...
Uploading: [============================================================] 100% Done...

21:49:04 [INFO]: Waiting for result...
21:49:05 [INFO]: Result: OK

And the new FS is now loaded on the device.

With the change the non-OTA FS updates are still functional.

[becks0815]

I can confirm this. Tried to upload a program which uses littlefs via ota. Got the same response
Uploading: [============================================================] 100% Done...

22:36:48 [ERROR]: ERROR[10]:
*** [uploadfsota] Error 1

After changing main.py like mentioned above the error was gone.

[theplen]

Agreed,

platform-espressif8266/builder/main.py

Line 311 in bb547ce

if "uploadfs" in COMMAND_LINE_TARGETS:

Changed to:
if "uploadfsota" in COMMAND_LINE_TARGETS:

Fixes the "Upload Filesystem Image OTA" issue.

[crazyduck]

Working also for me.
How can this change be integrated in latest ESP8266 pio files?

Thanks for showing this up

[kmomberg]

Also worked for me. Thanks. 👍
Any idea when this change will be made official? or at least some other that address this issue.

[Helix70]

This fixed it for me too. Not sure why this is not being adopted into the code, it is pretty clear.

[lycheejp]

Super merci beaucoup cela fonctionne parfaitement de mon coté

[itldg]

This solved my problem, thanks