This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Rename env variable to correct env variable used in atom #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environmental variable 'ATOM_SHELL_INTERNAL_RUN_AS_NODE' was renamed in the atom source code to 'ELECTRON_RUN_AS_NODE a while back, but was apparently never changed in the platformio-terminal code. Changing 'ATOM_SHELL_INTERNAL_RUN_AS_NODE' to 'ELECTRON_RUN_AS_NODE' in the 'process.coffee' file seems to resolve the issues people have been having not being able to run various commands in the terminal.
|
Thanks a lot! |
|
@Fred-Barclay unfortunately it wont for many of those on windows. The issue is that 'env' variable does not get passed properly or sent to the terminal instance, and I traced it down to pty.js being VERY outdated with tons of known issues. Specifically, see my comments in #112 See microsoft/vscode#13625 notably, which leads to node-pty being the only currently maintained pty fork that I could find. |
|
I have confirmed that 2.4.0 did NOT fix atleast #112 |
|
Does not fix #51 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environmental variable
ATOM_SHELL_INTERNAL_RUN_AS_NODEwas renamed in the atom source code toELECTRON_RUN_AS_NODEa while back, but was apparently never changed in theplatformio-terminal code. Changing
ATOM_SHELL_INTERNAL_RUN_AS_NODEtoELECTRON_RUN_AS_NODEin thelib/process.coffeefile seems to resolve the issues people have been having not being able to run various commands in the terminal.