Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix focus (ctrl+alt+F) shortcut behaviour #218

Merged
merged 3 commits into from
May 20, 2017
Merged

Fix focus (ctrl+alt+F) shortcut behaviour #218

merged 3 commits into from
May 20, 2017

Conversation

pietrodn
Copy link

@pietrodn pietrodn commented Apr 26, 2017

Previous behaviour:

Current behaviour:

@pietrodn pietrodn changed the title Fix focus issue when terminal is not active Fix focus (ctrl+alt+F) shortcut behaviour Apr 26, 2017
@Smithx10
Copy link

Is this going to get merged? It's driving me crazy.

@Fred-Barclay
Copy link

@ivankravets It's a good PR. 😄 I've got it in my fork and it's been working great these past weeks.
(Doesn't change #227 though.)

@ivankravets ivankravets merged commit b2be663 into platformio:master May 20, 2017
@Smithx10
Copy link

@ivankravets thanks a billion!!! How long is the build + release process? :) I'd love to update and being using this!!!!!

@ivankravets
Copy link
Member

@Smithx10 Done!

https://github.com/platformio/platformio-atom-ide-terminal/releases/tag/v2.5.1

@Smithx10
Copy link

w00h0000 UPDATING!@

@Smithx10
Copy link

Smithx10 commented May 20, 2017

This isn't working as expected, cmd + alt + f focus's, cmd +alt +f doesn't return to the editor on the mac. :(
Update it is only working with "LeftAlt + cmd + f" . Might be a bug with "RightAlt + cmd +f"

@ivankravets
Copy link
Member

Would be thankful if someone improves this PR. We are currently busy with upcoming release of PlatformIO IDE 2.0 and PIO Unified Debugger.

@Fred-Barclay
Copy link

@Smithx10 Do Macs handle RightAlt differently than LeftAlt?

@isaacjwilliams
Copy link

@Smithx10 I'm experiencing the same problem! I bound ctrl-; to 'platformio-ide-terminal:focus'. It switches focus to the terminal correctly, but when I invoke it again, it does nothing at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants