This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Focus fix 3 #276
Merged
Focus fix 3 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for PR. Let's wait when other people report related issues. if we will not have them, I make new release. |
|
Sure. Thank you for your efforts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This focus stuff sure is tricky...
@ivankravets I found this bug related to PR #251 and #275
It happens when you switch window focus without using the mouse, e.g. when using Alt+Tab.
The lastActiveElement is then the input of the terminal, not the terminal itself.
I hope this is the last bug related to this PR, I was at least not able to find more.