Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InoToCpp: add ':' to arguments regexp #4586

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

mcspr
Copy link
Contributor

@mcspr mcspr commented Mar 31, 2023

Noticed while building .ino files at esp8266 repo
https://github.com/esp8266/Arduino/actions/runs/4578253831/jobs/8084637114?pr=8901#step:5:174

  /tmp/tmpo60cxu_1/src/onewiretest.ino: In function 'void loop()':
  /tmp/tmpo60cxu_1/src/onewiretest.ino:31:2: error: 'checkSwSerial' was not declared in this scope
     31 |  checkSwSerial(&swSer1);
        |  ^~~~~~~~~~~~~
  *** [.pio/build/nodemcuv2/src/onewiretest.ino.cpp.o] Error 1

Where the signature should be

void checkSwSerial(EspSoftwareSerial::UART*);

Locally, to reproduce

> git clone https://github.com/plerup/espsoftwareserial/
> pushd espsoftwareserial/examples/onewiretest
> pio ci -b esp32dev -l "$PWD/../../" ./

@ivankravets
Copy link
Member

Thanks for the PR! 🙏

@ivankravets ivankravets merged commit 71bb84f into platformio:develop Apr 7, 2023
ivankravets added a commit that referenced this pull request Apr 12, 2023
ivankravets added a commit that referenced this pull request Apr 12, 2023
Revert "InoToCpp: add ':' to arguments regexp (#4586)"

This reverts commit 71bb84f.
@mcspr mcspr deleted the ino-ns-arg branch June 18, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants