Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant workers access to app storage #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tylers-username
Copy link
Contributor

Warning

This change fixes the template but it is not compatible with Lando. See lando/platformsh#68

Description (*)

This resolves an issue with the deploy script only making the deployed configuration available to the app but not the worker by changing the storage configuration to network storage.

Fixed Issues (if relevant)

  1. Health al

Manual testing scenarios (*)

  1. Create project from template
  2. Manually trigger the worker command within the worker container platform ssh --worker app--queue 'bin/magento queue:consumers:start async.operations.all --single-thread --max-messages=10000'

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@gilzow
Copy link
Contributor

gilzow commented Sep 26, 2022

PR environment is fine, no errors in the logs, everything looks 👍

@tylers-username
Copy link
Contributor Author

I didn't realize it earlier, but for the time being, when workers are enabled a Medium plan is required. If this is to be accepted, we'd want to update the template summary and readme as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants