-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase PHP version requirement to 8.2 #1506
Open
pjcdawkins
wants to merge
5
commits into
main
Choose a base branch
from
upgrade-php-8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcdawkins
force-pushed
the
upgrade-php-8
branch
2 times, most recently
from
November 24, 2024 09:41
0868be4
to
0d16efd
Compare
pjcdawkins
force-pushed
the
upgrade-php-8
branch
3 times, most recently
from
December 3, 2024 23:25
60e488e
to
de6cf13
Compare
pjcdawkins
force-pushed
the
upgrade-php-8
branch
from
December 5, 2024 16:33
de6cf13
to
1cbc165
Compare
@akalipetis as far as I can see the main blocker here is version numbers, we should probably increase the major version to reflect the backwards compatibility break, but version 5.x has kind of been 'claimed' by the Go CLI. I think the options are:
|
pjcdawkins
force-pushed
the
upgrade-php-8
branch
3 times, most recently
from
December 16, 2024 11:45
67cd944
to
6bfa2b6
Compare
pjcdawkins
force-pushed
the
upgrade-php-8
branch
2 times, most recently
from
December 16, 2024 16:10
96d61da
to
a1704bf
Compare
pjcdawkins
force-pushed
the
upgrade-php-8
branch
from
December 25, 2024 00:20
a1704bf
to
6f41a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would need a major version increase.
Backwards compatibility is very important to this project. But this is now a good time for a PHP version requirement increase.
Rationale:
This PR simply updates the PHP requirement. See the (much larger) pull requests #1507 for ugprading Guzzle and #1514 for upgrading Symfony.