getAccountInfo() Fails In 0.1.199 and Above

[reynoldsalec]

@gilzow and I have been trying to resolve a bug with the Platform.sh Lando integration, where upon running a lando init, we are unable to retrieve the user's project list via the getAccountInfo() function provided by platformsh-client-js.

Specifically the line that produces the ultimate error in Lando is https://github.com/lando/platformsh/blob/main/recipes/platformsh/init.js#L35

While trying different versions of platformsh-client, I did notice a change in behavior between 0.1.198 and 0.1.199 of platformsh-client-js; both versions fail to produce the project list, but on 0.1.198 no explicit error is produced (the process just seems to hang). It looks like the underlying function powering getAccountInfo() changed, as did the version of isomorphic-fetch...perhaps one of these changes might have produced this error? v0.1.198...v0.1.199

Hoping that your finely tuned eyes notice something I haven't, happy to jump on a screenshare if that's easier, should be able to ping me via Slack if you join the #lando-platformsh shared channel.

[rfay]

@gilzow could you please follow up here, and maybe we can figure out what's wrong here, and why it's not being caught by automated tests? Who would be the responsible person to assign this to?

[gilzow]

0.1.199 was released almost a year ago. @reynoldsalec have you tried updating the client to a more recent version? Is the error still present with a newer version of the client?

[reynoldsalec]

@gilzow yep, currently packaged version since the last release (December 12th) was 0.1.217: https://github.com/lando/platformsh/blob/main/yarn.lock#L3915

The reason I brought up 0.1.199 in particular is because the change in behavior I noticed when running all the versions trying to find an older version than 0.1.217 that would work.

[gilzow]

Gotcha. Just wanted to clarify.

@tlattimore / @shakaman - any ideas on what might be causing the issue above?

[tlattimore]

I will investigate this further but I can confirm the issue was introduced with the isomorphic-fetch bump in 0.1.199. The issue we are seeing has been reported by others at matthew-andrews/isomorphic-fetch#194. If anything, we can investigate moving away from isomorphic-fetch altogether.

[tlattimore]

@reynoldsalec regarding,

The reason I brought up 0.1.199 in particular is because the change in behavior I noticed when running all the versions trying to find an older version than 0.1.217 that would work.

Is it reasonable to assume it is just at version 0.1.217 is because that's the last time yarn install was run? I ask just to verify and check there isn't another reason you're at that version.

[reynoldsalec]

Exactly @tlattimore, that was the last time yarn install was run when the release was packaged up.

Good to hear RE: isomorphis-fetch...that was my suspicion based on "what changed" in those modules, but good catch with that issue. I'll dig into that and see if there's anything clever we can do to adapt in the short term.

Do you have any plans to move away from isomorphic-fetch?

[tlattimore]

I have started working this branch to test moving away from it isomorphic-fetch. Will be testing a bit more before we move forward with that.

[reynoldsalec]

Awesome, thanks @tlattimore, that is huge.

[gilzow]

@tlattimore has there been any updates to your branch you're working on? This issue is a pretty substantial road block for platform.sh customers who are using lando for their local development.

[tlattimore]

Hey @gilzow, this should now be resolved with 0.1.230 which is now available on npm.

[gilzow]

@tlattimore PERFECT! Thank you!
@reynoldsalec Can you try updating the lando platform plugin with this latest version and see if this corrects the issue? Thanks!

[reynoldsalec]

Awesome @tlattimore, I'll try updating this later today or tomorrow, thanks for the great work!

[reynoldsalec]

I think this resolved the issue...was still having a problem when trying with my account, but after refreshing my token it worked perfectly. Relevant tests seem to pass.

Going to roll this into our next Lando release, thanks again @tlattimore for your help and @gilzow + @rfay!