Fix eslint v9 compatibility issues (#532)

* Fix deprecated API usage for eslint v9 compatibility * Fix linting * Ignore coverage for code paths not traversed by modern eslint
platinumazure · Aug 16, 2024 · 02b4c8e · 02b4c8e
1 parent a74e161
commit 02b4c8e
Show file tree

Hide file tree

Showing 5 changed files with 49 additions and 10 deletions.
diff --git a/lib/rules/no-assert-equal.js b/lib/rules/no-assert-equal.js
@@ -136,10 +136,17 @@ module.exports = {
  testStack.pop();
  }
  },
- Program: function () {
+ Program: function (node) {
  // Gather all calls to global `equal()`.
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const sourceCode =
+ context.sourceCode ?? context.getSourceCode();
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const scope = sourceCode.getScope
+ ? sourceCode.getScope(node)
+ : context.getScope();
 
- const tracker = new ReferenceTracker(context.getScope());
+ const tracker = new ReferenceTracker(scope);
  const traceMap = { equal: { [ReferenceTracker.CALL]: true } };
 
  for (const { node } of tracker.iterateGlobalReferences(

diff --git a/lib/rules/no-global-assertions.js b/lib/rules/no-global-assertions.js
@@ -33,8 +33,16 @@ module.exports = {
 
  create: function (context) {
  return {
- Program: function () {
- const tracker = new ReferenceTracker(context.getScope());
+ Program: function (node) {
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const sourceCode =
+ context.sourceCode ?? context.getSourceCode();
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const scope = sourceCode.getScope
+ ? sourceCode.getScope(node)
+ : context.getScope();
+
+ const tracker = new ReferenceTracker(scope);
  const traceMap = {};
  for (const assertionName of getAssertionNames()) {
  traceMap[assertionName] = { [ReferenceTracker.CALL]: true };

diff --git a/lib/rules/no-global-expect.js b/lib/rules/no-global-expect.js
@@ -31,8 +31,16 @@ module.exports = {
 
  create: function (context) {
  return {
- Program: function () {
- const tracker = new ReferenceTracker(context.getScope());
+ Program: function (node) {
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const sourceCode =
+ context.sourceCode ?? context.getSourceCode();
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const scope = sourceCode.getScope
+ ? sourceCode.getScope(node)
+ : context.getScope();
+
+ const tracker = new ReferenceTracker(scope);
  const traceMap = { expect: { [ReferenceTracker.CALL]: true } };
 
  for (const { node } of tracker.iterateGlobalReferences(

diff --git a/lib/rules/no-global-module-test.js b/lib/rules/no-global-module-test.js
@@ -31,8 +31,16 @@ module.exports = {
 
  create: function (context) {
  return {
- Program: function () {
- const tracker = new ReferenceTracker(context.getScope());
+ Program: function (node) {
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const sourceCode =
+ context.sourceCode ?? context.getSourceCode();
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const scope = sourceCode.getScope
+ ? sourceCode.getScope(node)
+ : context.getScope();
+
+ const tracker = new ReferenceTracker(scope);
  const traceMap = {
  asyncTest: { [ReferenceTracker.CALL]: true },
  module: { [ReferenceTracker.CALL]: true },

diff --git a/lib/rules/no-global-stop-start.js b/lib/rules/no-global-stop-start.js
@@ -33,8 +33,16 @@ module.exports = {
  //--------------------------------------------------------------------------
 
  return {
- Program: function () {
- const tracker = new ReferenceTracker(context.getScope());
+ Program: function (node) {
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const sourceCode =
+ context.sourceCode ?? context.getSourceCode();
+ /* istanbul ignore next: deprecated code paths only followed by old eslint versions */
+ const scope = sourceCode.getScope
+ ? sourceCode.getScope(node)
+ : context.getScope();
+
+ const tracker = new ReferenceTracker(scope);
  const traceMap = {
  start: { [ReferenceTracker.CALL]: true },
  stop: { [ReferenceTracker.CALL]: true },